Skip to content

Silence warnings about -Wno-deprecated-non-prototype#989

Merged
mhucka merged 4 commits intotensorflow:masterfrom
mhucka:cxx-compilation-warnings
Feb 12, 2026
Merged

Silence warnings about -Wno-deprecated-non-prototype#989
mhucka merged 4 commits intotensorflow:masterfrom
mhucka:cxx-compilation-warnings

Conversation

@mhucka
Copy link
Member

@mhucka mhucka commented Feb 7, 2026

Builds were producing a great number of warnings like this:

cc1plus: warning: command-line option '-Wno-deprecated-non-prototype' is valid for C/ObjC but not for C++

These warnings came from a build option in the .bazelrc file written by configure.sh, specifically the application of -Wno-deprecated-non-prototype to C++ files in external dependencies even though the flag is only valid for C. This PR changes the Bazel build per_file_copt and host_per_file_copt regexes for -Wno-deprecated-non-prototype from external/.* to external/.*[.]c$ to target only C source files.

@mhucka mhucka added area/health Involves general matters of project configuration, health, maintenance, and similar concerns area/c++ Involves C++ code labels Feb 9, 2026
@mhucka mhucka added this pull request to the merge queue Feb 11, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 11, 2026
@mhucka mhucka enabled auto-merge (squash) February 12, 2026 05:15
@mhucka mhucka merged commit bb4a44d into tensorflow:master Feb 12, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/c++ Involves C++ code area/health Involves general matters of project configuration, health, maintenance, and similar concerns

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants